ControllerEmu: Allow changing the target gate radius of octagon sticks. #10682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-woyak
force-pushed
the
gate-size-setting
branch
from
7cd01e1
to
a8ffd59
Compare
|
@dolphin-emu-bot rebuild |
|
Works as I expected. 'Gate Size' seems fine as a name, too. The default values are bizarre but they are what they are I suppose. |
|
Wouldn't it make sense to also control the thickness of the notches as well as the angle? |
Maybe, but that's outside of the scope of this PR. I only moved the notches setting in the UI. |
|
Works like I would expect it to and your code is very nice to read :) |
…Virtual Notches" and "Gate Size" categorized as such.
jordan-woyak
force-pushed
the
gate-size-setting
branch
from
a8ffd59
to
4c40941
Compare
dvessel
pushed a commit
to dvessel/dolphin
that referenced
this pull request
Jun 28, 2022
ControllerEmu: Allow changing the target gate radius of octagon sticks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplemented feature from #10665.
I also moved "Virtual Notches" to the new dialog.
Do we like that?
What should the setting be called? "Gate Size", "Gate Radius"?