New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DolphinQt: Renamed "Range" to "Multiplier" in advanced mapping window and improved UX. #10710
Conversation
|
'Multiplier' maybe and remove the percentage? |
|
Isn't the option a bit superfluous after the input expression update? I think the people interested in a scaling option will be able to find the multiplication operator to achieve that and it could confuse people who aren't interested anyway. |
|
"Scalar" feels very non-explanatory to me. Range, scale and multiplier all seem like better options to me. |
Yeah, It's superfluous for inputs, but more work would have to be done to remove the option without breaking existing configs. Also it's still useful for outputs. "Multiplier" sounds fine to me. I think I'd leave the percentage symbol unless the 100 was changed to 1, but I was thinking |
|
We have to rip off the bandaid eventually, but this is a fine compromise imo. Multiplier with a % is fine. |
…. Removed the slider. Moved the spin box.
fa71087
to
87fb42b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. Should be merged after locking in the beta because it has a translatable string.
|
(We might want to allow >100% on Outputs (and clamp the actual value sent to the device) but that can be a separate PR.) |
The "Range" slider wasn't connected to anything.
The spin box behaved poorly because of the attempt to connect it to the slider.
I've removed the slider and relocated the spin box.
I've changed the maximum values to 1000% (for inputs) and 100% (for outputs).
A user in discord unsurprisingly made their rumble stop working with it set to like 104.
There's no use case for over 100 on outputs.
Negative values are still useful for inverting wheel force feedback.
I've renamed "Range" to "Multiplier".