New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Idle Skipping in JitIL. #1073

Merged
merged 1 commit into from Sep 13, 2014

Conversation

5 participants
@phire
Member

phire commented Sep 13, 2014

Has been broken since the flags-opt merge. The idle skipping code in
JitIL was very brittle and depended on the IL of it's inputs not
changing in any way.

flags-opt changed the IR generated by the cmp instruction, which is part
of the idle loop, causing JitIL to break in really weird ways, which
were almost impossible to track down.

This Fixes various wii games crashing/not booting and the Regspill
error on (all?) gamecube mmu games.

@JMC47 Could you do some testing on this?

@JMC47

This comment has been minimized.

Show comment
Hide comment
@JMC47

JMC47 Sep 13, 2014

Contributor

I booted all my Wii games on it, they work just fine.

I checked the MMU games. They barely work just like before the flagsopt. So yeah, this basically saves JITIL completely.

Contributor

JMC47 commented Sep 13, 2014

I booted all my Wii games on it, they work just fine.

I checked the MMU games. They barely work just like before the flagsopt. So yeah, this basically saves JITIL completely.

@delroth

This comment has been minimized.

Show comment
Hide comment
@delroth

delroth Sep 13, 2014

Member

@phire: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge.


Fix the typo, and feel free to merge.

@dolphin-emu-bot allowmerge

Member

delroth commented Sep 13, 2014

@phire: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge.


Fix the typo, and feel free to merge.

@dolphin-emu-bot allowmerge

Fix Idle Skipping in JitIL.
Has been broken since the flags-opt merge. The idle skipping code in
JitIL was very brittle and depended on the IL of it's inputs not
changing in any way.

flags-opt changed the IR generated by the cmp instruction, which is part
of the idle loop, causing JitIL to break in really weird ways, which
were almost impossible to track down.

This fixes various wii games crashing/not booting and the Regspill
error on (all?) gamecube mmu games.

dolphin-emu-bot added a commit that referenced this pull request Sep 13, 2014

Merge pull request #1073 from phire/save_jitil2
Fix Idle Skipping in JitIL.

@dolphin-emu-bot dolphin-emu-bot merged commit d72f61d into dolphin-emu:master Sep 13, 2014

1 check passed

default Build succeeded on the Buildbot.
Details

@phire phire deleted the phire:save_jitil2 branch Sep 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment