Fix Idle Skipping in JitIL. #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -138,14 +138,18 @@ void JitILBase::bcx(UGeckoInstruction inst) | |||
| else | |||
| destination = js.compilerPC + SignExt16(inst.BD << 2); | |||
|
|
|||
| // Idle skipping: | |||
| // The main Idle skipping is done in the LoadStore code, but there is an optimistaion here. | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I booted all my Wii games on it, they work just fine. I checked the MMU games. They barely work just like before the flagsopt. So yeah, this basically saves JITIL completely. |
|
@phire: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. Fix the typo, and feel free to merge. @dolphin-emu-bot allowmerge |
Has been broken since the flags-opt merge. The idle skipping code in JitIL was very brittle and depended on the IL of it's inputs not changing in any way. flags-opt changed the IR generated by the cmp instruction, which is part of the idle loop, causing JitIL to break in really weird ways, which were almost impossible to track down. This fixes various wii games crashing/not booting and the Regspill error on (all?) gamecube mmu games.
dolphin-emu-bot
added a commit
that referenced
this pull request
Sep 13, 2014
Fix Idle Skipping in JitIL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has been broken since the flags-opt merge. The idle skipping code in
JitIL was very brittle and depended on the IL of it's inputs not
changing in any way.
flags-opt changed the IR generated by the cmp instruction, which is part
of the idle loop, causing JitIL to break in really weird ways, which
were almost impossible to track down.
This Fixes various wii games crashing/not booting and the Regspill
error on (all?) gamecube mmu games.
@JMC47 Could you do some testing on this?