Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkCaptureLogger: Add GameCube BBA support #10833

Merged
merged 1 commit into from Jul 16, 2022

Conversation

sepalani
Copy link
Contributor

@sepalani sepalani commented Jul 11, 2022

This PR allows to dump BBA network traffic into a PCAP file.

It seems to produce a legit PCAP file when I entered LAN mode of Kirby Air Ride. I haven't tested it beyond this point.

A screenshot of the option in the Network widget:
image

Ready to be reviewed & tested.

@nolrinale
Copy link
Contributor

nolrinale commented Jul 11, 2022

Nothing is being intercepted while connecting to PSO online
image

But the PCAP file is being correctly generated inside the Dump/SSL folder
image

@sepalani
Copy link
Contributor Author

@nolrinale
If I understand correctly, there are missing packets in the PCAP file and it didn't capture packets while connecting to PSO online servers, am I right?

@nolrinale
Copy link
Contributor

Correct, I saw no output of any kind in this new window you created just the pcap file being created in the background.

Even running around the lobby, joining games, etc. The window remained completely empty all the time.

@sepalani
Copy link
Contributor Author

These tables are only useful in Wii mode because the Wii has a socket and SSL table (which the UI updates only when the emulator is paused, IIRC). That's not the case in GameCube mode (afaict) which use a broadband adapter. The only thing this PR does is logging everything into a PCAP file, that's all (i.e. don't expect a view like Wireshark).

That's why I'm asking if there are any missing packets in the PCAP file (i.e. UDP/TCP/ARP/... packets). If there are missing packets, I'll have to see which methods in Dolphin I need to hook to dump the missing packets.

@nolrinale
Copy link
Contributor

If that's the case I think it would be better you take a look at this pcap file it generated on Wireshark (I'm not knowledgeable with this software)
pcapfile.zip

@sepalani
Copy link
Contributor Author

The PCAP file seems complete to me, I can see the DNS request and the UDP/TCP packets.

@schthack
Are you familiar with the packets used by PSO and know if @nolrinale PCAP file is valid (i.e. doesn't have missing packets)?

@schthack
Copy link
Contributor

@sepalani The pcap file look good, i see the dhcp negociation, the ship select, block select and lobby/game

packet are encrypted so you cant realy see the data, but the ports/ip match

@AdmiralCurtiss
Copy link
Contributor

Sounds good to me then!

@AdmiralCurtiss AdmiralCurtiss merged commit 2ef069e into dolphin-emu:master Jul 16, 2022
@sepalani sepalani deleted the BBA-log branch July 24, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants