Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTReal: Treat libusb_get_string_descriptor_ascii failure as non-fatal warning #10878

Conversation

Pokechu22
Copy link
Contributor

See https://forums.dolphin-emu.org/Thread-unable-to-pair-remotes-hci-command-timeout, which was apparently introduced by #10729.

My guess as to what's happening here is that device_descriptor.iSerialNumber is 0, and libusb_get_string_descriptor_ascii doesn't like 0 as it indicates a special case, returning LIBUSB_ERROR_INVALID_PARAM in that case (which matches the log). However, I haven't tested this change at all.

Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. I've asked the person on the forums to check if this fixes it, let's see what they say.

@AdmiralCurtiss AdmiralCurtiss merged commit df399b0 into dolphin-emu:master Jul 22, 2022
@AdmiralCurtiss
Copy link
Contributor

This improved the situation but they're still having problems btw: https://forums.dolphin-emu.org/Thread-unable-to-pair-remotes-hci-command-timeout?pid=526505#pid526505

Anything in that log that sticks out for you? I'm not seeing anything obvious.

@Pokechu22
Copy link
Contributor Author

No, I don't see anything obvious either. It might be useful to compare to a log from a known-working version (and to make sure that pairing multiple still works in that old version), though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants