Metal: Prevent usage of macOS-only APIs on non-macOS platforms #10886
Conversation
OatmealDome
force-pushed
the
metal-minor-fixes
branch
from
122a926
to
2f46a6f
Compare
OatmealDome
force-pushed
the
metal-minor-fixes
branch
from
2f46a6f
to
700162b
Compare
|
I don't know Apple, but this has been approved by the Apple knowers, so... |
|
I'm getting Invalid Memory Access Locations errors when opening games since this commit. Relevant issue report: https://bugs.dolphin-emu.org/issues/12995 |
|
Are you sure this bisect is correct? This PR changes code that only runs on macOS, and you are running Windows 10. |
|
Going through all the recent builds one by one, 5.0-16986 (this PR) is the first build where the issue starts to occur. 5.0-16979 and prior doesn't have the issue. |
|
Do you have ESET NOD32? If not, what antivirus do you have? |
|
Hah, yes I have ESET nod32. |
|
Please disable NOD32 or whitelist Dolphin. For whatever reason, NOD32 thinks that our fastmem code is something suspicious and blocks it. (If you are using other emulators with fastmem, this may also apply to them.) |
In the spirit of keeping the differences between my iOS fork and upstream minimal (and since the Metal backend already has support for iOS), here's a bunch of changes to make sure Metal APIs that are unavailable on non-macOS platforms are not used when targeting non-macOS.