HLE_OS: Don't modify emulated state in printf hooks. #10925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about |
AdmiralCurtiss
force-pushed
the
ppc-state-hle-print
branch
from
e10373e
to
53364fc
Compare
|
Yeah, those should probably be removed too. Those fifoci diffs are curious... |
|
I'm pretty sure the fifoci diffs are a separate issue related the radeon builder using its Intel GPU instead of its AMD GPU for some reason; they're not directly caused by your change. (A similar thing happened a few days ago.) |
… PPC function will be called afterwards.
AdmiralCurtiss
force-pushed
the
ppc-state-hle-print
branch
from
53364fc
to
b364a30
Compare
sepalani
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hooks that call these are Start hooks, so the real PPC function is called afterwards and takes care of any state changes.