New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove _M_X86 in favour of _M_X86_64 #10965
Conversation
In Hash.cpp, GetHash64_SSE42_CRC32 has 32-bit variant which get compiled instead of the 64-bit variant if _M_X86 is defined while _M_X86_64 is not. This is clearly legacy code from when Dolphin still supported 32-bit, though, so you could probably remove it. |
There seems to be library code that only uses dolphin/Externals/zstd/lib/common/compiler.h Lines 92 to 105 in b667931
dolphin/Externals/liblzma/config.h Lines 154 to 157 in b667931
dolphin/Externals/liblzma/config.h Lines 370 to 374 in b667931
I'm not sure what to do about that. I think you can just edit the liblzma config, and |
178702b
to
ca8b6e0
Compare
I feel uneasy about it, but I've edited the liblzma files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase.
This removes an unnecessary definition, improves clarity and is functionally identical to before.