Jit64: Preserve inputs when software_fma && m_accurate_nans #11141
+30
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
jit64-soft-fma-nans-preserve
branch
2 times, most recently
from
d73568e
to
d35b9bf
Compare
JosJuice
force-pushed
the
jit64-soft-fma-nans-preserve
branch
from
d35b9bf
to
aa62f36
Compare
JosJuice
force-pushed
the
jit64-soft-fma-nans-preserve
branch
2 times, most recently
from
761070d
to
b91978b
Compare
dvessel
added a commit
to dvessel/dolphin
that referenced
this pull request
Jan 6, 2023
|
Makes sense and doesn't look obviously wrong. Untested. |
When writing the software FMA code, I didn't realize that we can't overwrite d if d is the same register as one of the inputs and HandleNaNs is going to be called. This fixes that.
JosJuice
force-pushed
the
jit64-soft-fma-nans-preserve
branch
from
b91978b
to
5e58a46
Compare
|
i'll take that as an approval |
gmbshad
added a commit
to gmbshad/dolphinUWP
that referenced
this pull request
Apr 10, 2024
…s-preserve Jit64: Preserve inputs when software_fma && m_accurate_nans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing the software FMA code, I didn't realize that we can't overwrite d if d is the same register as one of the inputs and HandleNaNs is going to be called. This fixes that.