DolphinQt: Fix window focus from unpausing after a manual pause. #11211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokechu22
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the "Pause on Focus Loss" setting will not unpause unless it actually performed the pause.
This fixes issue: https://bugs.dolphin-emu.org/issues/13071
I've purposely removed the
Config::Get(Config::MAIN_PAUSE_ON_FOCUS_LOST)check in theWindowActivateevent to produce the following desirable behavior:The user notices the emulator is pausing on focus loss but they don't want this.
They open the config (causing the emulator to automatically pause).
They disable the "Pause on Focus Loss" setting and close the config window.
The emulator automatically resumes, despite the setting now being disabled, because it was automatically paused previously.
This is what they want. They want the game to be running now.