Network/Socket: Enable broadcast permissions in socket requests #11568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I can write a hardware test to confirm (or not) that behaviour. I also have Mario Kart Wii so I can check the mod. |
That would be excellent on your part. Thank you. |
sepalani
reviewed
Feb 15, 2023
sepalani
suggested changes
Feb 18, 2023
Co-authored-by: sepalani <sepalani@hotmail.fr>
sepalani
approved these changes
Mar 4, 2023
There was a problem hiding this comment.
LGTM. Tested on Windows.
Side note regarding testing this build. It's based on a branch where some games can't boot (due to a JIT regression I suppose) so I had to switch to "Cached interpreter" for some of the games I tested. Otherwise, it doesn't seem to produce a network regression on my end.
|
Thank you for your work on this, @sepalani. Is there anything that remains to be done before this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a longstanding issue where Dolphin could not host or connect to LAN rooms when using the Mario Kart Wii LAN Multiplayer mod, available both standalone and in some custom track distributions. I have been unable to identify unmodified commercial games that benefit from this change.
I understand that Dolphin supports setting socket options when requested, but it seems that a real Wii console supports sending broadcast packets even without the permission being explicitly set. To be more specific, I do not see these permissions being requested by the mod, but I admit that I am no Wii networking expert.
I do not do error logging here, as it is a best-effort approach, and sockets not meant to broadcast seemingly fail to apply this option.