Update minimum GCC version in cmake enforcement to 10 #11585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++20 is required now, and GCC 10 is the minimum for the current C++20 features Dolphin uses
|
#10969 does a similar thing, but I'm not sure what's the status of that... |
|
Ah, didn't realize that PR existed. Mostly just did this as I noticed the detection already seemed to exist but fell behind, and some users have complained in the Discord over build failures due to using old gcc (gcc 9 will fail to build, gcc 10 will work) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++20 is required now, and GCC 10 is the minimum for the current C++20 features Dolphin uses