Android: Only show divider in settings for headers #11631
Conversation
...rc/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsDividerItemDecoration.kt
Outdated
Show resolved
Hide resolved
|
Could you apply this to the cheats list too? |
K0bin
force-pushed
the
pref-divider
branch
2 times, most recently
from
52d6ec8
to
f101892
Compare
|
Done. |
|
Could you also apply the built-in codestyle? You're using two spaces for indentation when it should be 4. |
|
It's configured to do 2 spaces. https://github.com/dolphin-emu/dolphin/blob/master/Source/Android/code-style-java.xml#L81-L82 |
|
Yes, but that's for the Java code. For Kotlin we're using the official style. I have it set in Admittedly it's a little confusing right now but I have a block on finishing the conversion of the project to Kotlin. |
|
I don't feel like this is necessarily the perfect solution, as there is some clarity issues with it like this, but the dividers as they are are way too strong and busy. Either the dividers need a total rework or they need to be removed. So, I think this is a net win even if it isn't "perfect". LGTM. |
Before:
After:
I think it looks much cleaner. I can't request a review, so I'll just ping @t895.