DolphinQt: StickWidget and IRWidget check for changed x/y before signaling change #11732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty inconsequential change, I just noticed this as I was skimming TAS-related code.
Even if your mouse moved ever-so-slightly as to not change the x/y position of the stick, or if you held down left-click and dragged your mouse off of the stick widget, it would continuously fire the ChangedX/Y signal as well as queue up a Qt re-draw for the widget.
I have no idea if this actually helps performance to any noticeable degree, but I just figured this is likely more beneficial than it could be harmful.This appears to reduce window latency issues encountered when holding down frame advance and rotating the stick at the same time. It does not get rid of the latency, but definitely reduces it.