Qt/GeneralWidget and GraphicsWidget: Remove unused member variable #11798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m_xrr_config was used by the GeneralWidget::GetAvailableResolutions function to get the list of supported fullscreen resolutions when HAVE_XRANDR was set. aa4088a removed the ability to set that resolution in the UI, leaving the GetAvailableResolutions function unused. m_xrr_config is initialized in MainWindow which still uses it to toggle fullscreen, but the references in GeneralWidget and GraphicsWidget (which just ferried m_xrr_config from MainWindow to GeneralWidget) are now unnecessary and removed in this commit.
Dentomologist
force-pushed
the
remove_obsolete_widget_member_variable
branch
from
dad93e0
to
b59ca96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m_xrr_config was used by the GeneralWidget::GetAvailableResolutions function to get the list of supported fullscreen resolutions when HAVE_XRANDR was set. #6196 removed the ability to set that resolution in the UI, leaving the GetAvailableResolutions function unused. I'm removing that function in #11797.
m_xrr_config is initialized in MainWindow which still uses it to toggle fullscreen, but the references in GeneralWidget and GraphicsWidget (which just ferried m_xrr_config from MainWindow to GeneralWidget) are now unnecessary and removed in this PR.