Android: Convert "features.input" package to Kotlin #11919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K0bin
approved these changes
Aug 14, 2023
JosJuice
reviewed
Aug 14, 2023
...c/main/java/org/dolphinemu/dolphinemu/features/input/model/controlleremu/ControlReference.kt
Outdated
Show resolved
Hide resolved
...main/java/org/dolphinemu/dolphinemu/features/input/model/controlleremu/EmulatedController.kt
Outdated
Show resolved
Hide resolved
...main/java/org/dolphinemu/dolphinemu/features/input/model/controlleremu/EmulatedController.kt
Outdated
Show resolved
Hide resolved
...main/java/org/dolphinemu/dolphinemu/features/input/model/controlleremu/EmulatedController.kt
Outdated
Show resolved
Hide resolved
...main/java/org/dolphinemu/dolphinemu/features/input/model/controlleremu/EmulatedController.kt
Outdated
Show resolved
Hide resolved
...e/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/input/ui/MotionAlertDialog.kt
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/input/ui/ProfileAdapter.kt
Outdated
Show resolved
Hide resolved
...roid/app/src/main/java/org/dolphinemu/dolphinemu/features/input/ui/ProfileDialogPresenter.kt
Outdated
Show resolved
Hide resolved
...e/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/input/ui/ProfileViewHolder.kt
Outdated
Show resolved
Hide resolved
...e/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/input/ui/ProfileViewHolder.kt
Show resolved
Hide resolved
t895
force-pushed
the
kotlin-controls
branch
5 times, most recently
from
3cadff7
to
d1fb82f
Compare
|
Just got through the review. I'm gonna do another quick once over and then we'll be good to go. |
|
Got some code style changes in and turns out I'm able to just use |
|
Just to double check that everything is working correctly with |
|
Ooh good catch (I've been working with Citra and yuzu a lot lately and the default build flavor uses minify 😅). Turns out I was slightly wrong. For |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.