Kill AsciiToHex #11920
Merged
Kill AsciiToHex #11920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shocked that the FreeBSD builder's copy of the standard library lacks something as simple as the iterator-based constructors for std::string_view added in C++20. Honestly not as shocked by Android. |
Minty-Meeo
force-pushed
the
kill-ascii-to-hex
branch
5 times, most recently
from
f75c3f9
to
172b3b1
Compare
|
If #11934 is approved, then this PR becomes dependent on the other, as it uses the operator-> overload to work around a C++20 standard library deficiency in Android and FreeBSD. |
Minty-Meeo
force-pushed
the
kill-ascii-to-hex
branch
3 times, most recently
from
783178d
to
ab7b1bd
Compare
|
Note to self: The additions in this PR are a candidate for future changes in the long-dormant #11034. |
Pokechu22
reviewed
Jun 22, 2023
Now superseded by Common::FromChars
Minty-Meeo
force-pushed
the
kill-ascii-to-hex
branch
from
ab7b1bd
to
445bf8d
Compare
Pokechu22
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now superseded by Common::FromChars