Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Re-add host thread check #11926

Merged
merged 4 commits into from Jun 19, 2023
Merged

Android: Re-add host thread check #11926

merged 4 commits into from Jun 19, 2023

Conversation

JosJuice
Copy link
Member

Not sure if I caught everything that needs a host lock, but at least now emulation and settings work with the host thread check enabled.

AdmiralCurtiss
AdmiralCurtiss approved these changes Jun 11, 2023
View reviewed changes
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't exactly test this or verify if you found all the locations that act as the host thread, but this looks reasonable.

@t895
Copy link
Contributor

t895 commented Jun 11, 2023

For some reason when I try to add games in the app, I get a crash from PauseAndLock. Can you repro this too?

@JosJuice
Copy link
Member Author

Fixed.

(I should replace the raw writing to INI files in GameFileCache at some point...)

@JosJuice JosJuice merged commit cff3e22 into dolphin-emu:master Jun 19, 2023
14 checks passed
@JosJuice JosJuice deleted the android-host-check branch June 19, 2023 18:38
@Medard22 Medard22 mentioned this pull request Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdmiralCurtiss AdmiralCurtiss AdmiralCurtiss approved these changes

@t895 t895 t895 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@JosJuice @t895 @AdmiralCurtiss