Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParallelProgressDialog: Initialize all data members #11938

Merged
merged 2 commits into from Jun 12, 2023
Merged

ParallelProgressDialog: Initialize all data members #11938

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b70894b
ParallelProgressDialog: Initialize all data members
lioncash Jun 12, 2023
9c0cd5c
ParallelProgressDialog: Mark WasCanceled() as const
lioncash Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/Core/DolphinQt/QtUtils/ParallelProgressDialog.h
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@ class ParallelProgressDialog final : public QObject
void SetValue(int progress) { emit SetValueSignal(progress); }

// Can be called from any thread
bool WasCanceled() { return m_was_cancelled.IsSet(); }
bool WasCanceled() const { return m_was_cancelled.IsSet(); }

signals:
void CancelSignal();
Expand Down Expand Up @@ -126,6 +126,6 @@ private slots:

QProgressDialog m_dialog;
Common::Flag m_was_cancelled;
int m_last_received_progress;
int m_last_received_progress = 0;
bool m_is_setting_value = false;
};