Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: Add '--recursive' to git submodule command #12041

Merged
merged 1 commit into from Jul 12, 2023

Conversation

bemug
Copy link
Contributor

@bemug bemug commented Jul 11, 2023

Not doing so results in the following error :

CMake Error at Externals/cubeb/CMakeLists.txt:30 (message):
Could not find sanitizers-cmake: run

git submodule update --init --recursive

in base git checkout

As the advice is correct, update readme with the correct command.

Not doing so results in the following error :

CMake Error at Externals/cubeb/CMakeLists.txt:30 (message):
  Could not find sanitizers-cmake: run

  	git submodule update --init --recursive

  in base git checkout

As the advice is correct, update readme with the correct command.
@Florin9doi
Copy link

You may add a -j $(nproc) as well, where supported

@bemug bemug closed this Jul 12, 2023
@bemug bemug reopened this Jul 12, 2023
@bemug
Copy link
Contributor Author

bemug commented Jul 12, 2023

My fat fingers clicked the close button without my brain wanting to. I apologize for the noise.

@Florin9doi -j$(nproc) is already mentionned further on the readme file.

@Florin9doi
Copy link

@Florin9doi -j$(nproc) is already mentionned further on the readme file.

Here it is used to compile using multiple jobs, but the submodule update process may also be speed up by running multiple jobs.

@bemug
Copy link
Contributor Author

bemug commented Jul 12, 2023

I was not aware that git submodule can take this argument, thanks.

The process was quite fast on my machine. Also as this is a readme I'd rather keep it simple. Thoughts ?

@AdmiralCurtiss
Copy link
Contributor

Yeah, I think this is fine as-is, I don't know how much speedup you can even get by parallelizing submodule checkout.

@AdmiralCurtiss AdmiralCurtiss merged commit 7f40c6f into dolphin-emu:master Jul 12, 2023
11 checks passed
@v1993
Copy link
Contributor

v1993 commented Jul 14, 2023

FWIW, I get quite a bit of speedup with -j4 option, but it probably should not be tied to thread count - the bottleneck of resulting processes is network and disk I/O and you probably don't want to open tons of actively used connections to github at once even if your CPU has a lot of (think 64+) threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants