Disable Wii Save Options When Emulation Is Running #12093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Exporting saves goes through IOS emulation code so I can see how the operation can fail when a game is running, but why are you also disabling "Open Wii Save Folder"? The user can still access that folder directly while a game is running via other means, so I'm not sure what exactly this would prevent/avoid... |
|
Oh sorry, I thought it would have been better to make it work like the WX ui, I can remove that. I think that this change should be kept though because it would be better to make it harder for a user to touch a wii save during emulation than to do nothing at all. |
mbc07
approved these changes
Aug 11, 2023
AdmiralCurtiss
force-pushed
the
exportWiiSaveErrorFix
branch
from
57485f2
to
1336979
Compare
AdmiralCurtiss
force-pushed
the
exportWiiSaveErrorFix
branch
from
1336979
to
783ff26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with export wii save files that is detailed here.
Trying to export a wii save while emulation is running creates some error messages and then appears to export the wii save normally but these are options that, in the previous UI of dolphin, were disabled during emulation.