New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Expose color space settings #12095
Conversation
6c40e71
to
2ffee06
Compare
Good stuff.
|
de9ebac
to
65768f3
Compare
Everything should be in order now |
65768f3
to
d7d4698
Compare
} | ||
|
||
abstract val selectedValue: Int | ||
abstract val selectedValue: Any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Any
feels kind of ugly. What do you think of using an algebraic data type (using sealed
)? Then it would be clearer what types can be returned, and you would be able to use when
in place of if (item is FloatSliderSetting)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that a lot actually. Pushing that change now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you implemented isn't what I suggested, but I suppose what you implemented works too.
.../Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/model/FloatSetting.kt
Outdated
Show resolved
Hide resolved
d7d4698
to
42cb875
Compare
42cb875
to
c52bd62
Compare
We did support float settings before but we never showed anything past the decimal place before.
c52bd62
to
53fc344
Compare
LGTM |
As per @Filoppi 's request
HDR settings are not included because HDR support is not present in the app yet.