IOS: Remove unused member variable from SharedContentMap and UIDSys #12097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve unused-private-field warnings on Android.
|
Just checking, since I think this had to be done a while back because it would be free'd while |
|
As far as I can tell, yes. Each instance of UIDSys or SharedContentMap is a local variable and nothing in those functions is freeing or invalidating the FSCore that initialized it. Even if that did happen, I don't believe having a reference to an invalid FSCore would change whether it was safe to use the shared_ptr stored in m_fs. |
|
Yeah this should not change any behavior, it's just a raw reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused member variable m_fs_core from SharedContentMap and UIDSys to resolve unused-private-field warnings on Android.