MemoryViewWidget: Fix some characters being truncated #12127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some ASCII characters not being drawn properly on the memory view.
Without this PR, underscores aren't drawn on my system. Removing the
-1from(m_font_vspace - 1)fixes the underscore issue. However, it was drawn under the table cell's border and couldn't be seen unless I changed the address and move the cursor elsewhere. Adding 1~2 (pixels?) allows the underscore character to be drawn right above the cell border but without spacing between it. That's why I added an extra 2 (i.e. 4 in total) to have at least a bit of spacing between the underscore and the cell's (dotted) border.Before this PR:
This PR:
I'm open to suggestions if you've better ways to address this.
Ready to be reviewed & merged.