JitArm64: Resolve deprecated enum conversion warning #12135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would make sense to turn them into constexpr variables. |
Resolve warning caused by using values from two different enums in a conditional expression which was deprecated in c++20. The warning in question is clang -Wdeprecated-anon-enum-enum-conversion and gcc -Wenum-compare.
Dentomologist
force-pushed
the
jitarm64_resolve_deprecated_enum_conversion_warning
branch
from
44ec03d
to
a650a16
Compare
|
Done. While I was at it I moved DOUBLE_QBIT to the top of the list so it would be next to the relevant comment. |
JosJuice
approved these changes
Aug 24, 2023
Dentomologist
deleted the
jitarm64_resolve_deprecated_enum_conversion_warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve warning caused by using values from two different enums in a conditional expression which was deprecated in c++20.
The warning is -Wdeprecated-anon-enum-enum-conversion in clang and -Wenum-compare in gcc.
An alternate resolution would be to convert the anonymous enums into static constexpr variables, but I'm not sure if the enums are leftovers from earlier c++ versions or if there's still a good reason to have them.