DolphinQt: Fix decrease emulation speed hotkey rollover #12207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mhm, yeah not sure why it is this way, I agree that it sticking at the low value if you try to decrease at the lowest makes more sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior of the Decrease Emulation Speed hotkey results in an unintended resetting of speed. Pressing the hotkey allows speed to go from 100% to 90% all the way to 10%. A subsequent press of the hotkey will then cause a rollover back to 100% speed. Subsequent presses will bring speed down to 10% again, repeating the cycle. This does not match the behavior prior to the Qt migration, and I personally don't think it should act this way!