Fix endian error. allows loading of current games save even if the memca...

[LPFaint99]

No description provided.

[JMC47]

This fixes my issues with using a GCI folder. Btw @LPFaint99 apparently that was messing up the medabots save too in GCI folders, derp! I guess it had nothing to do with alphabetical order like I has assumed. Sorry for the misleading info.

[Sonicadvance1]

Seems a bit dirty to do a cast like this.
Could we not just change the GameCode from a u8[4] array to just a regular u32?
We only ever use this as a u32, not sure why it was chosen to be an array in the first place.
There is at least one other place in the code that is casting it to a u32 as well.

[LPFaint99]

Agreed, it was originally an array (along with every other field in gcmemorycard space) since before I started working on dolphin. I worked to convert some of the other fields, never got to all of them.

I realize looking at the code again, there is one other place where we compare the passed in m_GameCode (LE) to a (BE) gamecode.

So I changed it so we pass m_GameCode in as BE.

The type of the fields in the memorycard handling should be dealt with in a different PR,
(more effort needed to regression test, this defect is not really related to the type)

[Sonicadvance1]

I'm fine with that resolution for now.
LGTM

[comex]

Sure would be nice if the OS X buildbot didn't randomly go down.

[Icekhaos]

The buildbox is not a Hackintosh?