Contributing.md: Make our stance on leaked information explicit #12267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
contributing-leaks
branch
from
5f7469c
to
01c5eb7
Compare
|
I wonder if "confidental information about the GameCube or Wii" is good enough, or whether people can possibly see this as invitation to go like "oh, but I worked on Triforce lemme copy this over". Not sure how to extend on this though, in a way thats generic yet clear enough to get that point across. Maybe something like "about the GameCube, Wii or its associated hardware/software"? Otherwise, the rest looks good to me; and just like yourself I was surprised that we didn't have this in writing in here yet. |
JosJuice
force-pushed
the
contributing-leaks
branch
from
01c5eb7
to
221599f
Compare
|
I made the wording a bit broader and explicitly mentioned Triforce. |
BhaaLseN
approved these changes
Nov 2, 2023
dreamsyntax
suggested changes
Nov 2, 2023
mbc07
approved these changes
Nov 3, 2023
We have been operating on this principle for a while. Let's make it explicit so that new contributors know about it.
JosJuice
force-pushed
the
contributing-leaks
branch
from
221599f
to
a2a733f
Compare
AdmiralCurtiss
approved these changes
Nov 3, 2023
OatmealDome
approved these changes
Nov 3, 2023
dreamsyntax
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been operating on this principle for a while. Let's make it explicit so that new contributors know about it.
Feedback on wording and structure is welcome.