New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI, CodeDiffDialog: Fix table widget display issues, including dark style. #12271
Conversation
@AdmiralCurtiss Can you confirm these dark.qss changes? |
5f27ad1
to
6045681
Compare
If that (record) button fix is too random, I can move it elsewhere. |
6045681
to
bf0e2e5
Compare
bf0e2e5
to
6287bb9
Compare
@dreamsyntax I thought setting the record button fixed worked, but it still pops. I missed it, wasn't checking at the right time. Looks like the problem is setting the border size in the custom pushed stylesheet that's in codediff. I think setting it fixes it in the regular style, lol. |
I'm not too worried about that. The white block in dark theme is more relevant anyway. |
6287bb9
to
c94f80a
Compare
CodeDiffDialog: Fix QTableWidget UI issues
c94f80a
to
2a5147a
Compare
Sorry for being so pushy, but I think I wrangled it into submission. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good on Windows light/dark theme.
Latest commit resolves
#12265 (comment)
Before:
After:
Note that the top header text is no longer being cutoff.
Would help if people could test this. I don't know what window uses sorting arrows and I was just focused on fixing this one window.
I suggest adding dark.qss to the Styles folder for easy switching.