Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI, CodeDiffDialog: Fix table widget display issues, including dark style. #12271

Merged
merged 1 commit into from Nov 5, 2023

Conversation

TryTwo
Copy link
Contributor

@TryTwo TryTwo commented Nov 3, 2023

Before:
Dolphin_2RfncvIgR6
After:
Dolphin_tl3s9rfejq

Note that the top header text is no longer being cutoff.

Would help if people could test this. I don't know what window uses sorting arrows and I was just focused on fixing this one window.

I suggest adding dark.qss to the Styles folder for easy switching.

@TryTwo
Copy link
Contributor Author

TryTwo commented Nov 4, 2023

@AdmiralCurtiss Can you confirm these dark.qss changes?

@TryTwo
Copy link
Contributor Author

TryTwo commented Nov 4, 2023

If that (record) button fix is too random, I can move it elsewhere.

@TryTwo
Copy link
Contributor Author

TryTwo commented Nov 4, 2023

@dreamsyntax I thought setting the record button fixed worked, but it still pops. I missed it, wasn't checking at the right time. Looks like the problem is setting the border size in the custom pushed stylesheet that's in codediff. I think setting it fixes it in the regular style, lol.

@dreamsyntax
Copy link
Member

@dreamsyntax I thought setting the record button fixed worked, but it still pops. I missed it, wasn't checking at the right time. Looks like the problem is setting the border size in the custom pushed stylesheet that's in codediff. I think setting it fixes it in the regular style, lol.

I'm not too worried about that. The white block in dark theme is more relevant anyway.

CodeDiffDialog: Fix QTableWidget UI issues
@TryTwo
Copy link
Contributor Author

TryTwo commented Nov 4, 2023

Sorry for being so pushy, but I think I wrangled it into submission.

Copy link
Member

@dreamsyntax dreamsyntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good on Windows light/dark theme.
Latest commit resolves
#12265 (comment)

@AdmiralCurtiss AdmiralCurtiss merged commit 9d08c8a into dolphin-emu:master Nov 5, 2023
11 checks passed
@TryTwo TryTwo deleted the Qt_Display_Fixes branch November 5, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants