Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DolphinQt: Remove unnecessary qOverloads #12273

Merged
merged 1 commit into from Nov 12, 2023
Merged

DolphinQt: Remove unnecessary qOverloads #12273

merged 1 commit into from Nov 12, 2023

Conversation

Dentomologist
Copy link
Contributor

qOverload is used to disambiguate pointers to overloaded functions, but most of the usages in the code base were with non-overloaded functions.

@Dentomologist
DolphinQt: Remove unnecessary qOverloads
43e69d3 
qOverload is used to disambiguate pointers to overloaded functions, but
most of the usages in the code base were with non-overloaded functions.
dreamsyntax
dreamsyntax approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@dreamsyntax dreamsyntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I also noticed. Not sure if its a leftover from Qt5, but while doing work in Qt6 I do see this suggested.

@AdmiralCurtiss
Copy link
Contributor

I'm pretty sure Qt5 required this, yes. See eg. https://doc.qt.io/qt-5/qspinbox.html#valueChanged

mbc07
mbc07 approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@mbc07 mbc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In one hand, this likely breaks support for Qt5 even more, on the other hand, we officially support only Qt6+ and this results in a little bit cleaner code, so, all things considered, I'd say go for it...

@Tilka Tilka merged commit 166423a into dolphin-emu:master Nov 12, 2023
11 checks passed
@Dentomologist Dentomologist deleted the dolphinqt_remove_unnecessary_qoverloads branch November 12, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbc07 mbc07 mbc07 approved these changes

@dreamsyntax dreamsyntax dreamsyntax approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@Dentomologist @AdmiralCurtiss @mbc07 @dreamsyntax @Tilka