Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - small square in bottom right corner #12361

Merged

Conversation

LillyJadeKatrin
Copy link
Contributor

Fixed a bug in OSUI created by the challenge icons that caused a small rectangle to appear in the bottom right corner of the screen.

Fixed a bug in OSUI created by the challenge icons that caused a small rectangle to appear in the bottom right corner of the screen.
Copy link
Member

@dreamsyntax dreamsyntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Appreciate the fast effort finding and fixing the issue from @CasualPokePlayer and @LillyJadeKatrin !

@AdmiralCurtiss AdmiralCurtiss merged commit 7eb02ec into dolphin-emu:master Dec 8, 2023
11 checks passed
@dolphin-ci
Copy link

dolphin-ci bot commented Dec 24, 2023

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • aeon-charge-attack on mvk-osx-m1: diff
  • bk-tev on mvk-osx-m1: diff
  • burnout2-vehicletextures on mvk-osx-m1: diff
  • chibi-robo-fastdepth on mvk-osx-m1: diff
  • chibi-robo-zfighting on mvk-osx-m1: diff
  • custom-brawl-char on mvk-osx-m1: diff
  • dbz-depth on mvk-osx-m1: diff
  • DKCR-Char on mvk-osx-m1: diff
  • DKCR-fast-depth on mvk-osx-m1: diff
  • ea-pink on mvk-osx-m1: diff
  • ed-updated on mvk-osx-m1: diff
  • fishing-resort-map on mvk-osx-m1: diff
  • fortune-street-white-box on mvk-osx-m1: diff
  • f-zero-rain on mvk-osx-m1: diff
  • inverted-depth-range on mvk-osx-m1: diff
  • jb-shadow on mvk-osx-m1: diff
  • jd2-fmv on mvk-osx-m1: diff
  • jj-awae-mirrored on mvk-osx-m1: diff
  • kirby-logicop on mvk-osx-m1: diff
  • kirby-shadows on mvk-osx-m1: diff
  • last-story-shadows on mvk-osx-m1: diff
  • lego-star-wars-crane-shadow on mvk-osx-m1: diff
  • lm-mario-portrait on mvk-osx-m1: diff
  • luigi-shadows on mvk-osx-m1: diff
  • mario-baseball-shadows on mvk-osx-m1: diff
  • mario-golf-oob on mvk-osx-m1: diff
  • mario-tennis-menu on mvk-osx-m1: diff
  • melee-depth on mvk-osx-m1: diff
  • melee-lighting on mvk-osx-m1: diff
  • metroid-visor on mvk-osx-m1: diff
  • mii-channel on mvk-osx-m1: diff
  • milotic-texture on mvk-osx-m1: diff
  • mini-ninjas on mvk-osx-m1: diff
  • mkdd-babypark on mvk-osx-m1: diff
  • mkw-bridge on mvk-osx-m1: diff
  • mkwii-bluebox on mvk-osx-m1: diff
  • monkeyball-fuse on mvk-osx-m1: diff
  • mp2-scanner on mvk-osx-m1: diff
  • mp3-bloom on mvk-osx-m1: diff
  • mp7-text on mvk-osx-m1: diff
  • mtennis-zfreeze on mvk-osx-m1: diff
  • my-word-coach on mvk-osx-m1: diff
  • nddemo-bumpmapping on mvk-osx-m1: diff
  • nddemo-lighting on mvk-osx-m1: diff
  • nfsu-purplerect on mvk-osx-m1: diff
  • nfsu-reflections on mvk-osx-m1: diff
  • nhl-slap on mvk-osx-m1: diff
  • pbr-sfx on mvk-osx-m1: diff
  • pm-hc-jp on mvk-osx-m1: diff
  • quake-gx on mvk-osx-m1: diff
  • rs2-bumpmapping on mvk-osx-m1: diff
  • rs2-glass on mvk-osx-m1: diff
  • rs2-skybox on mvk-osx-m1: diff
  • rs2-zfreeze on mvk-osx-m1: diff
  • rs3-bumpmapping on mvk-osx-m1: diff
  • rs3-skybox2 on mvk-osx-m1: diff
  • sadx-ui on mvk-osx-m1: diff
  • sfa-shadows on mvk-osx-m1: diff
  • sf-assault-flashing on mvk-osx-m1: diff
  • shadow-eyes on mvk-osx-m1: diff
  • simpsons-game on mvk-osx-m1: diff
  • smb-mirror on mvk-osx-m1: diff
  • smg2-fog on mvk-osx-m1: diff
  • smg-marioeyes on mvk-osx-m1: diff
  • smg-mmg on mvk-osx-m1: diff
  • smg-roar on mvk-osx-m1: diff
  • sms-bubbles on mvk-osx-m1: diff
  • sms-coconut-drinks on mvk-osx-m1: diff
  • sms-gc on mvk-osx-m1: diff
  • sms-water on mvk-osx-m1: diff
  • soniccolors-mm on mvk-osx-m1: diff
  • sonic-riders-blur on mvk-osx-m1: diff
  • sonic-riders-zg-4p on mvk-osx-m1: diff
  • sonicriderszg-gb on mvk-osx-m1: diff
  • spyro-bloom on mvk-osx-m1: diff
  • spyro-depth on mvk-osx-m1: diff
  • ssbb-mod-lloyd on mvk-osx-m1: diff
  • ssbm-pointsize on mvk-osx-m1: diff
  • sw3-dt on mvk-osx-m1: diff
  • thps3-earlyz on mvk-osx-m1: diff
  • thps4-shadow on mvk-osx-m1: diff
  • tla-menu on mvk-osx-m1: diff
  • tos-invis-char on mvk-osx-m1: diff
  • tp-skin on mvk-osx-m1: diff
  • tsp3-pinkgrass on mvk-osx-m1: diff
  • vegas-party-depth on mvk-osx-m1: diff
  • viewitful-joe-distortion on mvk-osx-m1: diff
  • xblade-bloom on mvk-osx-m1: diff
  • xenoblade-menu on mvk-osx-m1: diff
  • ztp-grass on mvk-osx-m1: diff
  • zww-armos on mvk-osx-m1: diff
  • zww-water on mvk-osx-m1: diff
  • zww-waves on mvk-osx-m1: diff
  • aeon-charge-attack on mtl-osx-m1: diff
  • bk-tev on mtl-osx-m1: diff
  • burnout2-vehicletextures on mtl-osx-m1: diff
  • chibi-robo-fastdepth on mtl-osx-m1: diff
  • chibi-robo-zfighting on mtl-osx-m1: diff
  • custom-brawl-char on mtl-osx-m1: diff
  • dbz-depth on mtl-osx-m1: failed to render
  • DKCR-Char on mtl-osx-m1: diff
  • DKCR-fast-depth on mtl-osx-m1: diff
  • ea-pink on mtl-osx-m1: diff
  • ed-updated on mtl-osx-m1: diff
  • fishing-resort-map on mtl-osx-m1: diff
  • fortune-street on mtl-osx-m1: failed to render
  • fortune-street-white-box on mtl-osx-m1: failed to render
  • f-zero-rain on mtl-osx-m1: diff
  • inverted-depth-range on mtl-osx-m1: diff
  • jb-shadow on mtl-osx-m1: diff
  • jd2-fmv on mtl-osx-m1: diff
  • jj-awae-mirrored on mtl-osx-m1: diff
  • kirby-logicop on mtl-osx-m1: diff
  • kirby-shadows on mtl-osx-m1: diff
  • last-story-shadows on mtl-osx-m1: diff
  • lego-star-wars-crane-shadow on mtl-osx-m1: diff
  • lm-mario-portrait on mtl-osx-m1: diff
  • luigi-shadows on mtl-osx-m1: diff
  • mario-baseball-shadows on mtl-osx-m1: failed to render
  • mario-golf-oob on mtl-osx-m1: diff
  • mario-tennis-menu on mtl-osx-m1: diff
  • melee-depth on mtl-osx-m1: diff
  • melee-lighting on mtl-osx-m1: diff
  • metroid-visor on mtl-osx-m1: diff
  • mii-channel on mtl-osx-m1: diff
  • milotic-texture on mtl-osx-m1: diff
  • mini-ninjas on mtl-osx-m1: diff
  • mkdd-babypark on mtl-osx-m1: diff
  • mkw-bridge on mtl-osx-m1: diff
  • mkwii-bluebox on mtl-osx-m1: diff
  • monkeyball-fuse on mtl-osx-m1: diff
  • mp2-scanner on mtl-osx-m1: failed to render
  • mp3-bloom on mtl-osx-m1: diff
  • mp7-text on mtl-osx-m1: diff
  • mtennis-zfreeze on mtl-osx-m1: diff
  • my-word-coach on mtl-osx-m1: diff
  • nddemo-bumpmapping on mtl-osx-m1: diff
  • nddemo-lighting on mtl-osx-m1: diff
  • nfsu-purplerect on mtl-osx-m1: diff
  • nfsu-reflections on mtl-osx-m1: diff
  • nhl-slap on mtl-osx-m1: diff
  • pbr-sfx on mtl-osx-m1: diff
  • pm-hc-jp on mtl-osx-m1: diff
  • quake-gx on mtl-osx-m1: diff
  • rs2-bumpmapping on mtl-osx-m1: diff
  • rs2-glass on mtl-osx-m1: diff
  • rs2-skybox on mtl-osx-m1: diff
  • rs2-zfreeze on mtl-osx-m1: diff
  • rs3-bumpmapping on mtl-osx-m1: diff
  • rs3-skybox2 on mtl-osx-m1: diff
  • sadx-ui on mtl-osx-m1: diff
  • sfa-shadows on mtl-osx-m1: diff
  • sf-assault-flashing on mtl-osx-m1: diff
  • shadow-eyes on mtl-osx-m1: diff
  • simpsons-game on mtl-osx-m1: failed to render
  • smb-mirror on mtl-osx-m1: diff
  • smg2-fog on mtl-osx-m1: diff
  • smg-marioeyes on mtl-osx-m1: diff
  • smg-mmg on mtl-osx-m1: diff
  • smg-roar on mtl-osx-m1: diff
  • sms-bubbles on mtl-osx-m1: diff
  • sms-coconut-drinks on mtl-osx-m1: diff
  • sms-gc on mtl-osx-m1: diff
  • sms-water on mtl-osx-m1: diff
  • soniccolors-mm on mtl-osx-m1: diff
  • sonic-riders-blur on mtl-osx-m1: diff
  • sonic-riders-zg-4p on mtl-osx-m1: diff
  • sonicriderszg-gb on mtl-osx-m1: diff
  • spyro-bloom on mtl-osx-m1: diff
  • spyro-depth on mtl-osx-m1: failed to render
  • ssbb-mod-lloyd on mtl-osx-m1: diff
  • ssbm-pointsize on mtl-osx-m1: diff
  • sw3-dt on mtl-osx-m1: diff
  • thps3-earlyz on mtl-osx-m1: failed to render
  • thps4-shadow on mtl-osx-m1: failed to render
  • tla-menu on mtl-osx-m1: diff
  • tos-invis-char on mtl-osx-m1: diff
  • tp-skin on mtl-osx-m1: failed to render
  • tsp3-pinkgrass on mtl-osx-m1: diff
  • vegas-party-depth on mtl-osx-m1: diff
  • viewitful-joe-distortion on mtl-osx-m1: diff
  • xblade-bloom on mtl-osx-m1: diff
  • xenoblade-menu on mtl-osx-m1: diff
  • ztp-grass on mtl-osx-m1: failed to render
  • zww-armos on mtl-osx-m1: diff
  • zww-water on mtl-osx-m1: diff
  • zww-waves on mtl-osx-m1: diff

automated-fifoci-reporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants