Android: Fix crash when trying to edit gate size setting #12375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gate size is 79.37125 by default, and the step size is 0.5. Android throws an exception if we try to show the slider with the value set to something that isn't divisible by the step size. To avoid this problem, round the value.
JosJuice
commented
Dec 10, 2023
| settings, | ||
| BigDecimal((selection).toDouble()).round(MathContext(3)).toFloat() | ||
| ) | ||
| floatSetting.setFloat(settings, selection) |
There was a problem hiding this comment.
I'm not sure why this rounding was being done. @t895, any comment?
There was a problem hiding this comment.
I think this was an incorrect assumption about how precise our floating point settings were. This was from when I was trying to get float sliders to not break from precision issues for the color correction settings but when I try to use any float slider, things work fine in this build. Seems fine to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gate size is 79.37125 by default, and the step size is 0.5. Android throws an exception if we try to show the slider with the value set to something that isn't divisible by the step size. To avoid this problem, round the value.