Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameSettings: fix C4 texture tiling in Crash Nitro Kart #12430

Merged
merged 1 commit into from Dec 18, 2023

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Dec 17, 2023

For buttons and some character icons the game loads palleted PNGs and tiles the pallet indices directly into C4 textures but fails to take into account that PNG and C4 use opposite nibble orders. This causes adjacent pixel columns to be swapped, see issue 13370.

Also disable Immediate XFB for the Japanese release. It has the same black screen and flickering issues as the other regions.

Before:
broken

After:
fixed

For buttons and some character icons the game loads palleted PNGs and
tiles the pallet indices directly into C4 textures but fails to take
into account that PNG and C4 use opposite nibble orders. This causes
adjacent pixel columns to be swapped, see issue 13370.

Also disable Immediate XFB for the Japanese release. It has the same
black screen and flickering issues as the other regions.
@dolphin-ci
Copy link

dolphin-ci bot commented Dec 17, 2023

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • burnout2-vehicletextures on mvk-osx-m1: diff
  • djhero2-blend on mvk-osx-m1: diff
  • ea-pink on mvk-osx-m1: diff
  • hb-discgolf on mvk-osx-m1: diff
  • last-story-shadows on mvk-osx-m1: diff
  • mario-golf-oob on mvk-osx-m1: diff
  • MaS-LOG-wiimote on mvk-osx-m1: diff
  • mkw-bridge on mvk-osx-m1: diff
  • nhl-slap on mvk-osx-m1: diff
  • smg-mmg on mvk-osx-m1: diff
  • sms-water on mvk-osx-m1: diff
  • ssbb-mod-lloyd on mvk-osx-m1: diff
  • DKCR-Char on mtl-osx-m1: diff
  • DKCR-fast-depth on mtl-osx-m1: diff
  • et-vid on mtl-osx-m1: diff
  • fishing-resort-map on mtl-osx-m1: diff
  • inverted-depth-range on mtl-osx-m1: failed to render
  • major-minor on mtl-osx-m1: diff
  • mii-channel on mtl-osx-m1: diff
  • mkw-flags on mtl-osx-m1: diff
  • rs3-bumpmapping on mtl-osx-m1: failed to render
  • sms-water on mtl-osx-m1: failed to render
  • soa-black on mtl-osx-m1: failed to render
  • tla-menu on mtl-osx-m1: diff

automated-fifoci-reporter

@Tilka Tilka merged commit c188dc2 into dolphin-emu:master Dec 18, 2023
11 checks passed
@Tilka Tilka deleted the cnk_c4 branch December 18, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants