Fix aspect ratio heuristics getting stuck to a state #12435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filoppi
force-pushed
the
fix-aspect-ratio-stuck
branch
3 times, most recently
from
24341a9
to
f59cc05
Compare
… non widescreen) (`m_is_game_widescreen` variable) if the user first forced the aspect ratio to 16:9/4:3 and then set it back to Auto.
Filoppi
force-pushed
the
fix-aspect-ratio-stuck
branch
from
f59cc05
to
68c554e
Compare
…c old values when changing settings
Filoppi
force-pushed
the
fix-aspect-ratio-stuck
branch
from
68c554e
to
48fbbdb
Compare
AdmiralCurtiss
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix aspect ratio heuristics getting stuck to widescreen (or to non widescreen) (
m_is_game_widescreenvariable) if the user first forced the aspect ratio to 16:9/4:3 and then set it back to Auto.This specifically happens in games 2D main menus, which have no 3D graphics so the aspect ratio heuristics fail to determine whether the game was widescreen or not. The behaviour can be replicated in The Legend of Zelda: Four Swords Adventures 60Hz mode.
Video showcasing the problem:
https://github.com/dolphin-emu/dolphin/assets/7011366/fad3c4e3-ba1b-4c09-89f4-976ec3fac3d1