BitSet64: Fix iterator incrementation #12473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Group numbers and their bitcounts together in pairs, which allows for range-based loop iteration.
mitaclaw
reviewed
Dec 31, 2023
Use 1 of the same type as the stored value when shifting left. This prevents undefined behavior caused by shifting an int more than 31 bits. Previously iterator incrementation could either hang or prematurely report it had reached the end of the bitset.
Dentomologist
force-pushed
the
bitset64_fix_iterator_incrementation
branch
from
1c14d97
to
7dbf463
Compare
JosJuice
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 1 of the same type as the stored value when shifting left during BitSet iterator incrementation. This prevents undefined behavior caused by shifting an int more than 31 bits in BitSet64.
Previously iterator incrementation could either hang or prematurely report it had reached the end of the BitSet64.