Partially revert "DolphinQt/Assembler: improve translatability" #12511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the parts of commit c8c9928 that made translatability worse rather than better. Changing "Error in column %2" to "%1 in column %2" not only means that the translators have to check the i18n comments to know what word hides behind %1, but there's also the problem that the translator might need to translate "Error" in this context differently from the standalone string "Error". Having to copy-paste some HTML tags may be annoying for translators, but it's a far less serious problem.
|
For reference, this is how the Transifex editor handles these kinds of tags:
You just click on the tag and it copies the tag to the text box. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the parts of commit c8c9928 that made translatability worse rather than better. Changing "Error in column %2" to "%1 in column %2" not only means that the translators have to check the i18n comments to know what word hides behind %1, but there's also the problem that the translator might need to translate "Error" in this context differently from the standalone string "Error". Having to copy-paste some HTML tags may be annoying for translators, but it's a far less serious problem.