Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Get rid of some unannotated fallthrough cases #12523

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Core: Get rid of some unannotated fallthrough cases #12523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28e9382
EXI_DeviceAGP: Annotate fallthrough with [[fallthrough]]
lioncash Jan 23, 2024
adb79d4
WiimoteReal: Explicitly break instead of fallthrough in IsBalanceBoard()
lioncash Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/Core/Core/HW/EXI/EXI_DeviceAGP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,10 +344,10 @@ void CEXIAgp::ImmWrite(u32 _uData, u32 _uSize)
case 0xAE010000:
case 0xAE090000: // start DMA
m_eeprom_write_status = false; // ToDo: Verify with hardware which commands disable EEPROM CS
// Fall-through intentional
[[fallthrough]];
case 0xAE0A0000: // end DMA
m_eeprom_pos = 0;
// Fall-through intentional
[[fallthrough]];
default:
m_current_cmd = _uData;
m_return_pos = 0;
Expand Down
1 change: 1 addition & 0 deletions Source/Core/Core/HW/WiimoteReal/WiimoteReal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,7 @@ bool Wiimote::IsBalanceBoard()
"Failed to read from 0xa400fe, assuming Wiimote is not a Balance Board.");
return false;
}
break;
}
default:
break;
Expand Down