DolphinQt: Tweak the aspect ratio setting description #12609
Conversation
|
This looks good to me. @MayImilae Opinions? |
| "This will usually make proportions look distorted." | ||
| "<br><br><b>Custom</b>: Mimics a TV with the specified aspect ratio. " | ||
| "This is mostly intended to be used with aspect ratio cheats/mods." | ||
| "<br><br><b>Custom (Stretch)</b>: Similar to `Custom`, but stretches the picture as if to " |
There was a problem hiding this comment.
I'm not very happy with "stretches the picture as if to complete fill the TV".
How about...
Similar to 'Custom', but stretches the image to the specified aspect ratio. This will usually distort the image, and should not be used under normal circumstances.
There was a problem hiding this comment.
"stretches the image to the specified aspect ratio" sounds fine to me.
Do you have a preference for "picture" vs "image"? I'd be fine with either, but I think it looks better if we consistently use the same term throughout the description.
There was a problem hiding this comment.
I personally prefer image.
It's a very subtle english language thing, probably even regional, but to me, "picture" is the absolute final result after everything including display (literally photons into eyeballs level), whereas "image" is more generally referring to the pixels being made and sent to the display. For example, "that television has a nice picture" is referring to the televisions ability to emit the signal that was sent to it, while "points at television that's a nice image" is referring to what the signal being sent to the television. "that television has a nice image" is not a thing in american english, as far as I know.
I'm not sure the origins of that, I believe it's from television nomenclature? Language is weird. ┐(´-｀)┌
There was a problem hiding this comment.
I applied your suggestion, except I changed "distort the image" to "distort the image's proportions" to make it clearer what kind of distortion we're talking about. "Distort the image" on its own feels to me like to could be referring to anything from signal quality degradation to the image being cut off or sheared. I suppose since we're already talking about aspect ratios, the user might be able to infer what we mean, but I don't trust everyone to infer that.
Also tweaked the rest of the description to keep the terminology consistent.
With this, I intend to make it clearer that Auto, Force 4:3, Force 16:9 and Custom are really the same thing, just with the aspect ratio of the simulated TV being selected in a different way. I also extended the introduction in a way I feel will clarify things but which you are welcome to bikeshed :) I was thinking of this during the review of 41b19e2, but wanted to put it in a separate PR as to avoid blocking it on bikeshedding. I'm a bit unsure what to do about the word "analog" in "analog TV". I felt that repeating it for each of these options would be too repetitive. I suppose there's a reason why we used the word originally, but digital TVs do give you basically the same aspect ratio for GC/Wii games as analog TVs. (Of course, whether it's 4:3-like or 16:9-like depends on what aspect ratio you set in the TV's settings, but that's the case for widescreen CRTs too.)
JosJuice
force-pushed
the
aspect-ratio-description
branch
from
66b34de
to
28da316
Compare
With this, I intend to make it clearer that Auto, Force 4:3, Force 16:9 and Custom are really the same thing, just with the aspect ratio of the simulated TV being selected in a different way. I also extended the introduction in a way I feel will clarify things but which you are welcome to bikeshed :)
I was thinking of this during the review of PR #12438, but wanted to put it in a separate PR as to avoid blocking it on bikeshedding.
I'm a bit unsure what to do about the word "analog" in "analog TV". I felt that repeating it for each of these options would be too repetitive. I suppose there's a reason why we used the word originally, but digital TVs do give you basically the same aspect ratio for GC/Wii games as analog TVs. (Of course, whether it's 4:3-like or 16:9-like depends on what aspect ratio you set in the TV's settings, but that's the case for widescreen CRTs too.)