Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aspect ratio swapping in Pitfall: The Lost Expedition #12629

Merged
merged 1 commit into from Mar 17, 2024

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Mar 10, 2024

Based on Billiard's recommendations in this discussion: https://discord.com/channels/521709831132807179/521711075721478145/1216164450936160417

I've tested a handful of menus, cutscenes, FMVs, and the first 10 minutes of gameplay. I still want to play past the final boss with this before publishing the PR because I know the post-credit loads have weird aspect ratio even on console.
Myself and another community member have played through the entire game, including minigames, w/o issue.

@Avasam Avasam marked this pull request as ready for review March 11, 2024 06:24
@AdmiralCurtiss AdmiralCurtiss merged commit 0bfa64b into dolphin-emu:master Mar 17, 2024
11 checks passed
@Avasam Avasam deleted the GPH-aspect-ratio branch March 17, 2024 05:15
@DaRkL3AD3R
Copy link

Just curious if this is a similar problem/solution to Star Wars: Rogue Squadron 2/3 having aspect ratio swapping as well. I set Dolphin to Forced 4:3 and yet it still does vert- zoom in widescreen for cutscenes.

@jordan-woyak
Copy link
Member

Just curious if this is a similar problem/solution to Star Wars: Rogue Squadron 2/3 having aspect ratio swapping as well. I set Dolphin to Forced 4:3 and yet it still does vert- zoom in widescreen for cutscenes.

If forcing AR doesn't work around the problem it sounds unrelated.

@AdmiralCurtiss
Copy link
Contributor

Rogue Squadron uses the VI registers to put letterboxes on its cutscenes, and Dolphin only consides the active image area for calulating the optimal output resolution to resize to within the render window. So this is technically by design. One would have to define a sub-area within the render window that may be resized into to 'fix' that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants