PPCSymbolDB: Move instance to PowerPCManager #12630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitaclaw
force-pushed
the
ppc-symbols-global
branch
from
bf31d0d
to
88cbca7
Compare
mitaclaw
force-pushed
the
ppc-symbols-global
branch
from
88cbca7
to
c24fa93
Compare
AdmiralCurtiss
approved these changes
Mar 17, 2024
There was a problem hiding this comment.
I see nothing wrong here. There's a few instances where I suspect the PPCSymbolDB isn't const-correct due to being a global before (very easy to overlook that there if your access to it is always non-const...), but that can easily be fixed in a followup if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPCSymbolDBis now owned byPowerPC::PowerPCManager, accessible via theGetSymbolDB()getter.Core::Systemalso has a new getter,GetPPCSymbolDB(), which is shorthand forGetPowerPC().GetSymbolDB(). In this PR, care has been taken to accessPPCSymbolDBthrough aPowerPC::PowerPCManagerreference whenever possible for efficiency.In HLE.cpp, the result of
SymbolDB::GetSymbolsFromNameis returned by value but was being bound to an auto reference, which I felt was misleading even though the lifetime (I think) is extended in this case, so I changed it.