Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing InputBackend classes. #12632

Merged
merged 8 commits into from Apr 13, 2024

Conversation

jordan-woyak
Copy link
Member

@jordan-woyak jordan-woyak commented Mar 11, 2024

This makes the handling of input backends uniform within ControllerInterface.cpp.
End behavior should be mostly unchanged.

This is a precursor to some future input-related cleanups.

@jordan-woyak jordan-woyak force-pushed the input-backend-impls branch 2 times, most recently from 53ae073 to b9210d3 Compare March 11, 2024 08:21
Copy link
Member

@Tilka Tilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I can't test it on Windows atm.

Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm Windows still works, both XInput and WGInput.

@jordan-woyak
Copy link
Member Author

Linux + Windows still work as expected for me. I have no way to test macOS, but I don't really expect it to be broken.

@Tilka Tilka merged commit e62d8ec into dolphin-emu:master Apr 13, 2024
11 checks passed
@jordan-woyak jordan-woyak deleted the input-backend-impls branch April 13, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants