GCAdapter: Adjust libusb transfer timeout to 100ms. #12654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't imagine you'd actually get a satisfying experience on a controller with 100ms of latency, but I suppose it is better than it not working at all, yeah. |
Maybe it was an occasional lag spike over 16ms that was making things terrible for usbip? I'm not sure exactly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for PR #5799.
Apparently the 16ms timeout can be a little too tight for usbip.
Fixes: https://bugs.dolphin-emu.org/issues/10408
100ms is mentioned to be satisfactory.
Note that transfers are done in threads. Increasing this timeout will not slow down emulation. It will reduce the responsiveness of controllers when the higher timeouts were necessary, as opposed to entirely not working.