Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSPHLE/Zelda: simplify AFC decoding #12693

Merged
merged 1 commit into from Apr 13, 2024
Merged

DSPHLE/Zelda: simplify AFC decoding #12693

merged 1 commit into from Apr 13, 2024

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Apr 7, 2024 •
edited

Current compilers don't seem to optimize this automatically.

https://alive2.llvm.org/ce/z/dbNnec

AdmiralCurtiss
AdmiralCurtiss approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to test out if this is really equivalent but yup it is.

@AdmiralCurtiss AdmiralCurtiss merged commit 1bfeeb8 into dolphin-emu:master Apr 13, 2024
11 checks passed
@Tilka Tilka deleted the zelda3 branch April 13, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdmiralCurtiss AdmiralCurtiss AdmiralCurtiss approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@Tilka @AdmiralCurtiss