Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSPHLE/Zelda: set COMBINED_CMD_0D flag appropriately #12694

Merged
merged 1 commit into from
May 5, 2024

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Apr 7, 2024

All relevant games other than Pikmin 1 Wii seem to always set the two dwords to zero, so previously they were ignored during command dispatch and now we still ignore them but in the right place.

All relevant games other than Pikmin 1 Wii seem to always set the two
dwords to zero, so previously they were ignored during command dispatch
and now we still ignore them but in the right place.
@Tilka Tilka requested a review from delroth April 20, 2024 11:59
@JMC47
Copy link
Contributor

JMC47 commented Apr 30, 2024

LGTM

@Tilka Tilka merged commit 98529a9 into dolphin-emu:master May 5, 2024
11 checks passed
@Tilka Tilka deleted the zelda4 branch May 5, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants