Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change JitState::downcountAmount to a u32 #12717

Merged
merged 1 commit into from Apr 20, 2024
Merged

Change JitState::downcountAmount to a u32 #12717

merged 1 commit into from Apr 20, 2024

Conversation

mitaclaw
Copy link
Contributor

@mitaclaw mitaclaw commented Apr 19, 2024 •
edited

Almost every place I found pretends this is unsigned anyway. PatchEngine acknowledges downcountAmount is an int... and casts a u32 into an int in doing so. BeginProfiling and EndProfiling I wrote, so I know that's fine to change too. BlockStats::numCycles only ever has unsigned values added to it, and only ever adds to downcountAmount.

@JosJuice JosJuice merged commit 758097f into dolphin-emu:master Apr 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamsyntax dreamsyntax dreamsyntax approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@mitaclaw @dreamsyntax @JosJuice