Expression: Support All SPRs + MSR #12738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitaclaw
force-pushed
the
expression-sprs
branch
from
893939f
to
ea840ad
Compare
|
While you're working on that could you check the help file and make sure it has the correct capitalization (or lack of it) for the registers? I t think it says PC when it should be pc? Maybe add a note that it supports all registers in the register widget. |
mitaclaw
force-pushed
the
expression-sprs
branch
from
ea840ad
to
fcd152e
Compare
mitaclaw
changed the title
mitaclaw
force-pushed
the
expression-sprs
branch
2 times, most recently
from
df841c7
to
e16221b
Compare
|
For the love of all that is holy, when are we going to update that FreeBSD builder? |
AdmiralCurtiss
approved these changes
May 4, 2024
|
I have tested a few new SPRs ("srr0", "srr1"), as well as handling invalid SPR names (I fixed a segfault in my last force push from not handling those correctly). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not including
SPR_ASR, because I'm led to believe that isn't actually a real special-purpose register for PowerPC 750cl, only 64-bit PowerPC.