Core::SetState: Avoid Global System Accessor #12761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitaclaw
force-pushed
the
core-global-system-5
branch
from
70b870e
to
0b04975
Compare
AdmiralCurtiss
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 5 of an effort to remove global state from one of the biggest offenders. This is my last planned change to Core.cpp, leaving
Core::DisplayMessageandCore::SaveScreenshotunchanged. I believe these remaining uses ofCore::System::GetInstanceare open design questions that shouldn't be tackled in the same way I have for the other functions.