IOS/USB Add 2 more Spaces for Disney Infinity figures #12771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deReeperJosh
changed the title
JosJuice
reviewed
May 12, 2024
...id/app/src/main/java/org/dolphinemu/dolphinemu/features/infinitybase/ui/FigureSlotAdapter.kt
Outdated
Show resolved
Hide resolved
deReeperJosh
force-pushed
the
moreinfinityslots
branch
from
6c94ca0
to
33a414e
Compare
deReeperJosh
force-pushed
the
moreinfinityslots
branch
from
33a414e
to
a87ea69
Compare
AdmiralCurtiss
approved these changes
Jun 21, 2024
|
@AdmiralCurtiss I could convert the numbers in the switch case to an enum for clarity? |
|
Sure, that would be better, but do it in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was raised to me by a user that pointed out that you can have 2 "Power Discs" underneath the playset/power disc in the Hexagon space on the infinity base, so I have added 2 more slots to the qt and android UIs, as well as changing the behaviour of one of the C++ methods to allow for this. Removed the infinityListPosition from the Android version, as now the position in the UI list is ordered and doesn't need to have a separate UI list position and backend base position.