Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Put all unit tests in one binary #12837

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Jun 6, 2024

We currently have 32 different binaries containing unit tests. At least when I build for Android, each one takes up over 200 MiB, and linking them all increases my incremental build times by over a minute. I'd like to change this for the sake of my productivity and disk space.

For reference, MSBuild is already putting all tests in a single binary.

We currently have 32 different binaries containing unit tests. At least
when I build for Android, each one takes up over 200 MiB, and linking
them all increases my incremental build times by over a minute. I'd
like to change this for the sake of my productivity and disk space.

For reference, MSBuild is already putting all tests in a single binary.
Copy link
Contributor

@AdmiralCurtiss AdmiralCurtiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, I've always wondered why we generate separate executables for the tests.

@AdmiralCurtiss AdmiralCurtiss merged commit 04c246d into dolphin-emu:master Jun 10, 2024
11 checks passed
@JosJuice JosJuice deleted the cmake-one-tests-binary branch June 11, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants