Suppress extract success message when quiet flag is set #12839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvllsvm
force-pushed
the
fix_extract_success_quiet
branch
from
c1f5509
to
896bb50
Compare
|
I wonder why everything is printed to stderr... But regardless, this change LGTM. |
AdmiralCurtiss
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--quietflag should suppress all non-error messages.This change is useful in a personal wrapper I have around
dolphin-tool(and other extract tools). My wrapper outputs it's own extraction success messages, but allows any warnings/errors to be displayed. Sincedolphin-tool extractoutputs everything to stderr, this PR would negate me having to capture and filter stderr to suppress the success message. displayed immediately. https://github.com/nvllsvm/dotfiles/blob/7456f47280aa7f5e1f7385225c41a5335cba7148/scripts/terminal/archive#L802-L813